[
https://issues.apache.org/jira/browse/TAJO-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516788#comment-14516788
]
ASF GitHub Bot commented on TAJO-1450:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/465#discussion_r29231055
--- Diff: tajo-core/src/test/java/org/apache/tajo/storage/TestRowFile.java
---
@@ -128,8 +128,8 @@ public void test() throws IOException {
scanner = new RowFile.RowFileScanner(conf, schema, meta, fragment);
scanner.init();
while ((tuple=scanner.next()) != null) {
- if (!idSet.remove(tuple.get(0).asInt4())) {
- System.out.println("duplicated! " + tuple.get(0).asInt4());
+ if (!idSet.remove(tuple.getInt4(0))) {
+ System.out.println("duplicated! " + tuple.getInt4(0));
--- End diff --
Even though you didn't change this line, it looks unnecessary. Would you
remove it?
> Encapsulate Datum in Tuple
> --------------------------
>
> Key: TAJO-1450
> URL: https://issues.apache.org/jira/browse/TAJO-1450
> Project: Tajo
> Issue Type: Task
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Fix For: 0.11.0
>
>
> Currently, Tuple exposes Datum inside of it but it seemed not necessary(,
> which is not fully confirmed). If we remove Datum returning APIs from Tuple,
> Tuple can be implemented more effective and free. I think this can be a
> subtask of vectorization.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
