[
https://issues.apache.org/jira/browse/TAJO-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14966090#comment-14966090
]
ASF GitHub Bot commented on TAJO-1877:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/808#discussion_r42575412
--- Diff:
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
---
@@ -427,29 +408,20 @@ public void dropTablespace(String tableSpaceName)
throws UndefinedTablespaceExce
}
private Collection<String> getAllTablespaceNamesInternal(@Nullable
String whereCondition) {
- Connection conn = null;
- PreparedStatement pstmt = null;
- ResultSet resultSet = null;
-
List<String> tablespaceNames = new ArrayList<>();
- try {
- String sql = "SELECT SPACE_NAME FROM " + TB_SPACES;
+ String sql = "SELECT SPACE_NAME FROM " + TB_SPACES;
- if (whereCondition != null) {
- sql += " WHERE " + whereCondition;
- }
+ if (whereCondition != null) {
+ sql += " WHERE " + whereCondition;
+ }
- conn = getConnection();
- pstmt = conn.prepareStatement(sql);
- resultSet = pstmt.executeQuery();
+ try (ResultSet resultSet =
getConnection().prepareStatement(sql).executeQuery()) {
--- End diff --
PreparedStatement is not closed.
> Adopt try-resource statement to AbstractDBStore
> -----------------------------------------------
>
> Key: TAJO-1877
> URL: https://issues.apache.org/jira/browse/TAJO-1877
> Project: Tajo
> Issue Type: Sub-task
> Components: Catalog
> Reporter: Hyunsik Choi
> Assignee: Dongkyu Hwangbo
> Labels: newbie
>
> See
> https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html.
> JDK 7 introduced try-resource statement for better resource allocation and
> deallocation. We can also adopt this feature to AbstractDBStore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
