[
https://issues.apache.org/jira/browse/TAJO-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970411#comment-14970411
]
ASF GitHub Bot commented on TAJO-1877:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/835#discussion_r42832211
--- Diff:
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
---
@@ -1134,13 +1068,11 @@ private void setProperties(final int tableId, final
KeyValueSetProto properties)
final String updateSql = "UPDATE " + TB_OPTIONS + " SET VALUE_=? WHERE
TID=? AND KEY_=?";
final String insertSql = "INSERT INTO " + TB_OPTIONS + " (TID, KEY_,
VALUE_) VALUES(?, ?, ?)";
- Connection conn;
PreparedStatement pstmt = null;
Map<String, String> oldProperties = getTableOptions(tableId);
- try {
- conn = getConnection();
+ try (Connection conn = getConnection()) {
--- End diff --
Why do you close the connection here?
> Adopt try-resource statement to AbstractDBStore
> -----------------------------------------------
>
> Key: TAJO-1877
> URL: https://issues.apache.org/jira/browse/TAJO-1877
> Project: Tajo
> Issue Type: Sub-task
> Components: Catalog
> Reporter: Hyunsik Choi
> Assignee: Dongkyu Hwangbo
> Labels: newbie
>
> See
> https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html.
> JDK 7 introduced try-resource statement for better resource allocation and
> deallocation. We can also adopt this feature to AbstractDBStore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
