[
https://issues.apache.org/jira/browse/TAJO-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14970413#comment-14970413
]
ASF GitHub Bot commented on TAJO-1877:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/835#discussion_r42832316
--- Diff:
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
---
@@ -2640,13 +2480,12 @@ public void addPartitions(String databaseName,
String tableName, List<CatalogPro
@Override
public void createIndex(final IndexDescProto proto)
throws UndefinedDatabaseException, UndefinedTableException,
DuplicateIndexException {
- Connection conn = null;
PreparedStatement pstmt = null;
final String databaseName =
proto.getTableIdentifier().getDatabaseName();
final String tableName =
CatalogUtil.extractSimpleName(proto.getTableIdentifier().getTableName());
- try {
+ try (Connection conn = getConnection()) {
--- End diff --
Why do you close the connection here?
> Adopt try-resource statement to AbstractDBStore
> -----------------------------------------------
>
> Key: TAJO-1877
> URL: https://issues.apache.org/jira/browse/TAJO-1877
> Project: Tajo
> Issue Type: Sub-task
> Components: Catalog
> Reporter: Hyunsik Choi
> Assignee: Dongkyu Hwangbo
> Labels: newbie
>
> See
> https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html.
> JDK 7 introduced try-resource statement for better resource allocation and
> deallocation. We can also adopt this feature to AbstractDBStore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
