[
https://issues.apache.org/jira/browse/TAJO-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15001770#comment-15001770
]
ASF GitHub Bot commented on TAJO-1946:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/839#discussion_r44626380
--- Diff:
tajo-plan/src/main/java/org/apache/tajo/plan/logical/EvalExprNode.java ---
@@ -54,30 +54,30 @@ public boolean hasTargets() {
}
@Override
- public void setTargets(Target[] targets) {
+ public void setTargets(List<Target> targets) {
this.exprs = targets;
this.setOutSchema(PlannerUtil.targetToSchema(targets));
}
@Override
- public Target[] getTargets() {
+ public List<Target> getTargets() {
return exprs;
}
- public Target[] getExprs() {
+ public List<Target> getExprs() {
return this.exprs;
}
@Override
public String toString() {
- return "EvalExprNode (" + StringUtils.join(exprs) + ")";
+ return "EvalExprNode (" + StringUtils.join(exprs.toArray(new
Target[exprs.size()])) + ")";
--- End diff --
How about add a new ```join()``` method which takes a list of objects as
its parameter?
> Change Projectable::setTargets and getTargets to set and get List<Target>
> -------------------------------------------------------------------------
>
> Key: TAJO-1946
> URL: https://issues.apache.org/jira/browse/TAJO-1946
> Project: Tajo
> Issue Type: Sub-task
> Components: Planner/Optimizer
> Reporter: Hyunsik Choi
> Assignee: Dongkyu Hwangbo
> Priority: Minor
> Labels: newbie
>
> See TAJO-1938. It would simplify lots of codes for 'for-loop' on Targets if
> we change {{Projectable::setTargets}} and {{getTargets}} to set and get
> {{List<Target>}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
