[
https://issues.apache.org/jira/browse/TAJO-1946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006764#comment-15006764
]
ASF GitHub Bot commented on TAJO-1946:
--------------------------------------
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/839#issuecomment-157063994
I left some comments above.
In addition to them, it would be better to make ```targets``` variable's
behavior consistent. In some classes, ```targets``` can be null, but in others,
it cannot. I think it should be initialized as null and has a reference when
```setTargets()``` is called.
> Change Projectable::setTargets and getTargets to set and get List<Target>
> -------------------------------------------------------------------------
>
> Key: TAJO-1946
> URL: https://issues.apache.org/jira/browse/TAJO-1946
> Project: Tajo
> Issue Type: Sub-task
> Components: Planner/Optimizer
> Reporter: Hyunsik Choi
> Assignee: Dongkyu Hwangbo
> Priority: Minor
> Labels: newbie
>
> See TAJO-1938. It would simplify lots of codes for 'for-loop' on Targets if
> we change {{Projectable::setTargets}} and {{getTargets}} to set and get
> {{List<Target>}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
