Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/846#discussion_r45292402
--- Diff:
tajo-storage/tajo-storage-hdfs/src/main/java/org/apache/tajo/storage/FileTablespace.java
---
@@ -477,12 +503,17 @@ public long getMinSplitSize() {
return diskIds;
}
+ public List<Fragment> getSplits(String tableName, TableMeta meta, Schema
schema, Path... inputs)
+ throws IOException {
+ return getSplits(tableName, meta, schema, null, inputs);
+ }
+
/**
* Generate the list of files and make them into FileSplits.
*
* @throws IOException
*/
- public List<Fragment> getSplits(String tableName, TableMeta meta, Schema
schema, Path... inputs)
+ public List<Fragment> getSplits(String tableName, TableMeta meta, Schema
schema, String[] partitions, Path... inputs)
--- End diff --
I'm going to give a suggestion. We need to keep each method for one purpose
if possible. That approach would keep logic simpler.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
