Github user hyunsik commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/846#discussion_r45301565
  
    --- Diff: 
tajo-storage/tajo-storage-hdfs/src/main/proto/StorageFragmentProtos.proto ---
    @@ -32,3 +32,14 @@ message FileFragmentProto {
       repeated string hosts = 5;
       repeated int32 disk_ids = 6;
     }
    +
    +message PartitionedFileFragmentProto {
    +  required string id = 1;
    +  required string path = 2;
    +  required int64 start_offset = 3;
    +  required int64 length = 4;
    +  repeated string hosts = 5;
    +  repeated int32 disk_ids = 6;
    +  // Partition Name: country=KOREA/city=SEOUL
    +  required string partitionName = 7;
    --- End diff --
    
    In my opionion, partitionKeys would be more proper because the attribute 
includes concatenated partition keys.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to