[ 
https://issues.apache.org/jira/browse/TAJO-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031373#comment-15031373
 ] 

ASF GitHub Bot commented on TAJO-1971:
--------------------------------------

Github user eminency commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/890#discussion_r46111380
  
    --- Diff: 
tajo-core/src/main/java/org/apache/tajo/engine/query/TaskRequestImpl.java ---
    @@ -241,8 +241,8 @@ private void mergeLocalToBuilder() {
                        builder.setId(this.id.getProto());
                }
                if (fragments != null) {
    -                   for (int i = 0; i < fragments.size(); i++) {
    -                           builder.addFragments(fragments.get(i));
    +                   for (FragmentProto fragment : fragments) {
    +                           builder.addFragments(fragment);
    --- End diff --
    
    Use 2 spaces instead of tab character.


> Replace 'for' loop with 'foreach'
> ---------------------------------
>
>                 Key: TAJO-1971
>                 URL: https://issues.apache.org/jira/browse/TAJO-1971
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Dongkyu Hwangbo
>            Assignee: Dongkyu Hwangbo
>            Priority: Trivial
>              Labels: newbie
>
> Reports for loops which iterate over collections or arrays, and can be 
> replaced with the foreach iteration syntax, available in Java 5 and newer, to 
> get the improvement of readability and so on.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to