[
https://issues.apache.org/jira/browse/TAJO-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037325#comment-15037325
]
ASF GitHub Bot commented on TAJO-1971:
--------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/890#issuecomment-161527780
The patch looks good to me. Could you change some suffix ``1`` in
partitionName1? If you have concern with similar look between partitionName and
partitionNames, it would be better if you use ``aName`` instead of
partitionName.
> Replace 'for' loop with 'foreach'
> ---------------------------------
>
> Key: TAJO-1971
> URL: https://issues.apache.org/jira/browse/TAJO-1971
> Project: Tajo
> Issue Type: Improvement
> Reporter: Dongkyu Hwangbo
> Assignee: Dongkyu Hwangbo
> Priority: Trivial
> Labels: newbie
>
> Reports for loops which iterate over collections or arrays, and can be
> replaced with the foreach iteration syntax, available in Java 5 and newer, to
> get the improvement of readability and so on.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)