[
https://issues.apache.org/jira/browse/TAJO-1971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037337#comment-15037337
]
ASF GitHub Bot commented on TAJO-1971:
--------------------------------------
Github user dkhwangbo commented on a diff in the pull request:
https://github.com/apache/tajo/pull/890#discussion_r46516074
--- Diff:
tajo-core/src/main/java/org/apache/tajo/engine/query/TaskRequestImpl.java ---
@@ -35,113 +35,113 @@
public class TaskRequestImpl implements TaskRequest {
- private TaskAttemptId id;
- private List<FragmentProto> fragments;
- private String outputTable;
- private boolean isUpdated;
- private boolean clusteredOutput;
- private PlanProto.LogicalNodeTree plan; // logical node
- private Boolean interQuery;
- private List<FetchImpl> fetches;
- private QueryContext queryContext;
- private DataChannel dataChannel;
- private Enforcer enforcer;
- private String queryMasterHostAndPort;
-
- private TaskRequestProto proto = TaskRequestProto.getDefaultInstance();
- private TaskRequestProto.Builder builder = null;
- private boolean viaProto = false;
-
- public TaskRequestImpl() {
- builder = TaskRequestProto.newBuilder();
- this.id = null;
- this.isUpdated = false;
- }
-
- public TaskRequestImpl(TaskAttemptId id, List<FragmentProto> fragments,
-
String outputTable, boolean clusteredOutput,
-
PlanProto.LogicalNodeTree plan, QueryContext queryContext,
DataChannel channel,
-
Enforcer enforcer, String queryMasterHostAndPort) {
- this();
- this.set(id, fragments, outputTable, clusteredOutput, plan,
queryContext, channel, enforcer, queryMasterHostAndPort);
- }
-
- public TaskRequestImpl(TaskRequestProto proto) {
- this.proto = proto;
- viaProto = true;
- id = null;
- isUpdated = false;
- }
-
- public void set(TaskAttemptId id, List<FragmentProto> fragments,
- String outputTable, boolean clusteredOutput,
- PlanProto.LogicalNodeTree plan, QueryContext
queryContext,
-
DataChannel dataChannel, Enforcer enforcer, String queryMasterHostAndPort) {
- this.id = id;
- this.fragments = fragments;
- this.outputTable = outputTable;
- this.clusteredOutput = clusteredOutput;
- this.plan = plan;
- this.isUpdated = true;
+ private TaskAttemptId id;
--- End diff --
You mean, rollback this and fix with another jira? got it.
> Replace 'for' loop with 'foreach'
> ---------------------------------
>
> Key: TAJO-1971
> URL: https://issues.apache.org/jira/browse/TAJO-1971
> Project: Tajo
> Issue Type: Improvement
> Reporter: Dongkyu Hwangbo
> Assignee: Dongkyu Hwangbo
> Priority: Trivial
> Labels: newbie
>
> Reports for loops which iterate over collections or arrays, and can be
> replaced with the foreach iteration syntax, available in Java 5 and newer, to
> get the improvement of readability and so on.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
