[ 
https://issues.apache.org/jira/browse/TAJO-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15182765#comment-15182765
 ] 

ASF GitHub Bot commented on TAJO-2064:
--------------------------------------

Github user blrunner commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/955#discussion_r55175302
  
    --- Diff: tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java ---
    @@ -374,11 +387,43 @@ private void initCommands() {
             System.err.println(e.getMessage());
             throw new RuntimeException(e.getMessage());
           }
    +
    +      // make completers for console auto-completion
    +      compList.add(cmd.getArgumentComplementer());
    +
           commands.put(cmd.getCommand(), cmd);
           for (String alias : cmd.getAliases()) {
             commands.put(alias, cmd);
           }
         }
    +
    +    cliCompleter = new AggregateCompleter(compList);
    +
    +    sqlCompleter = new ArgumentCompleter(
    +        new ArgumentCompleter.AbstractArgumentDelimiter() {
    +          @Override
    +          public boolean isDelimiterChar(CharSequence buf, int pos) {
    +            char c = buf.charAt(pos);
    +            return Character.isWhitespace(c) || 
!(Character.isLetterOrDigit(c)) && c != '_';
    +          }
    +        },
    +        new StringsCompleter(getKeywords())
    +    );
    +  }
    +
    +  private Collection<String> getKeywords() {
    +    List<String> klist = new ArrayList<>();
    --- End diff --
    
    It looks like a ambiguous name. How about rename it to ``keywords`` or 
``keywordList``?


> Supporting auto-completion in Tsql
> ----------------------------------
>
>                 Key: TAJO-2064
>                 URL: https://issues.apache.org/jira/browse/TAJO-2064
>             Project: Tajo
>          Issue Type: Improvement
>          Components: Tools
>    Affects Versions: 0.11.0
>            Reporter: Jongyoung Park
>            Assignee: Jongyoung Park
>            Priority: Minor
>
> It is a task to support auto-completion on Tsql by tab key like Bash shell.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to