[ 
https://issues.apache.org/jira/browse/TAJO-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184352#comment-15184352
 ] 

ASF GitHub Bot commented on TAJO-2064:
--------------------------------------

Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/955#issuecomment-193593546
  
    @eminency 
    
    Thanks for your reflection.
    
    Well, I have one more suggestion. Currently, Tajo provides a SQL grammar 
file as following:
    
    
https://github.com/apache/incubator-tajo/blob/master/tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLLexer.g4
    
    But if we have existing grammar file and ``SQLKeywords``, when other 
contributors add new grammar, they must add it to above two files. I think that 
it is a little inefficient for maintaing codes. Even though it may be trouble, 
if you use ``SQLLexer.g4``, this patch will be better. For reference, there are 
some unnecessary keywords to ``SQLLexter.g4`` on tsql. So you need to filter 
theme at ``TajoCli::getKeywords``.



> Supporting auto-completion in Tsql
> ----------------------------------
>
>                 Key: TAJO-2064
>                 URL: https://issues.apache.org/jira/browse/TAJO-2064
>             Project: Tajo
>          Issue Type: Improvement
>          Components: Tools
>    Affects Versions: 0.11.0
>            Reporter: Jongyoung Park
>            Assignee: Jongyoung Park
>            Priority: Minor
>
> It is a task to support auto-completion on Tsql by tab key like Bash shell.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to