[ 
https://issues.apache.org/jira/browse/TAJO-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184175#comment-15184175
 ] 

ASF GitHub Bot commented on TAJO-2064:
--------------------------------------

Github user eminency commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/955#discussion_r55304007
  
    --- Diff: 
tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoGetConfCommand.java
 ---
    @@ -55,4 +62,52 @@ public String getUsage() {
       public String getDescription() {
         return "execute a tajo getconf command.";
       }
    +
    +  @Override
    +  public ArgumentCompleter getArgumentComplementer() {
    +    TajoConf.ConfVars[] vars = TajoConf.ConfVars.values();
    +    List<String> confNames = new ArrayList<>();
    +
    +    for(TajoConf.ConfVars varname: vars) {
    +      confNames.add(varname.varname);
    +    }
    +
    +    return new ArgumentCompleter(
    +        new StringsCompleter(getCommand()),
    +        new ConfCompleter(confNames.toArray(new String[confNames.size()])),
    +        NullCompleter.INSTANCE);
    +  }
    +}
    +
    +class ConfCompleter extends StringsCompleter {
    --- End diff --
    
    I think it is a good suggestion.


> Supporting auto-completion in Tsql
> ----------------------------------
>
>                 Key: TAJO-2064
>                 URL: https://issues.apache.org/jira/browse/TAJO-2064
>             Project: Tajo
>          Issue Type: Improvement
>          Components: Tools
>    Affects Versions: 0.11.0
>            Reporter: Jongyoung Park
>            Assignee: Jongyoung Park
>            Priority: Minor
>
> It is a task to support auto-completion on Tsql by tab key like Bash shell.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to