Github user blrunner commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/955#discussion_r55175302
  
    --- Diff: tajo-cli/src/main/java/org/apache/tajo/cli/tsql/TajoCli.java ---
    @@ -374,11 +387,43 @@ private void initCommands() {
             System.err.println(e.getMessage());
             throw new RuntimeException(e.getMessage());
           }
    +
    +      // make completers for console auto-completion
    +      compList.add(cmd.getArgumentComplementer());
    +
           commands.put(cmd.getCommand(), cmd);
           for (String alias : cmd.getAliases()) {
             commands.put(alias, cmd);
           }
         }
    +
    +    cliCompleter = new AggregateCompleter(compList);
    +
    +    sqlCompleter = new ArgumentCompleter(
    +        new ArgumentCompleter.AbstractArgumentDelimiter() {
    +          @Override
    +          public boolean isDelimiterChar(CharSequence buf, int pos) {
    +            char c = buf.charAt(pos);
    +            return Character.isWhitespace(c) || 
!(Character.isLetterOrDigit(c)) && c != '_';
    +          }
    +        },
    +        new StringsCompleter(getKeywords())
    +    );
    +  }
    +
    +  private Collection<String> getKeywords() {
    +    List<String> klist = new ArrayList<>();
    --- End diff --
    
    It looks like a ambiguous name. How about rename it to ``keywords`` or 
``keywordList``?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to