Github user eminency commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/955#discussion_r55304007
  
    --- Diff: 
tajo-cli/src/main/java/org/apache/tajo/cli/tsql/commands/TajoGetConfCommand.java
 ---
    @@ -55,4 +62,52 @@ public String getUsage() {
       public String getDescription() {
         return "execute a tajo getconf command.";
       }
    +
    +  @Override
    +  public ArgumentCompleter getArgumentComplementer() {
    +    TajoConf.ConfVars[] vars = TajoConf.ConfVars.values();
    +    List<String> confNames = new ArrayList<>();
    +
    +    for(TajoConf.ConfVars varname: vars) {
    +      confNames.add(varname.varname);
    +    }
    +
    +    return new ArgumentCompleter(
    +        new StringsCompleter(getCommand()),
    +        new ConfCompleter(confNames.toArray(new String[confNames.size()])),
    +        NullCompleter.INSTANCE);
    +  }
    +}
    +
    +class ConfCompleter extends StringsCompleter {
    --- End diff --
    
    I think it is a good suggestion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to