Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/955#issuecomment-193593546
@eminency
Thanks for your reflection.
Well, I have one more suggestion. Currently, Tajo provides a SQL grammar
file as following:
https://github.com/apache/incubator-tajo/blob/master/tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLLexer.g4
But if we have existing grammar file and ``SQLKeywords``, when other
contributors add new grammar, they must add it to above two files. I think that
it is a little inefficient for maintaing codes. Even though it may be trouble,
if you use ``SQLLexer.g4``, this patch will be better. For reference, there are
some unnecessary keywords to ``SQLLexter.g4`` on tsql. So you need to filter
theme at ``TajoCli::getKeywords``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
