[
https://issues.apache.org/jira/browse/TAJO-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259796#comment-15259796
]
ASF GitHub Bot commented on TAJO-2130:
--------------------------------------
Github user eminency commented on a diff in the pull request:
https://github.com/apache/tajo/pull/1007#discussion_r61223109
--- Diff:
tajo-core/src/main/java/org/apache/tajo/engine/function/geoip/GeoIPCountryInet4.java
---
@@ -1,54 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.tajo.engine.function.geoip;
-
-import org.apache.tajo.catalog.Column;
-import org.apache.tajo.common.TajoDataTypes;
-import org.apache.tajo.common.TajoDataTypes.Type;
-import org.apache.tajo.datum.Datum;
-import org.apache.tajo.datum.NullDatum;
-import org.apache.tajo.datum.TextDatum;
-import org.apache.tajo.plan.function.GeneralFunction;
-import org.apache.tajo.engine.function.annotation.Description;
-import org.apache.tajo.engine.function.annotation.ParamTypes;
-import org.apache.tajo.storage.Tuple;
-import org.apache.tajo.util.GeoIPUtil;
-
-@Description(
- functionName = "geoip_country_code",
- description = "Convert an ipv4 address to a geoip country code.",
- example = "> SELECT geoip_country_code(8.8.8.8);\n"
- + "US",
- returnType = TajoDataTypes.Type.TEXT,
- paramTypes = {@ParamTypes(paramTypes = {Type.INET4})}
-)
-public class GeoIPCountryInet4 extends GeneralFunction {
--- End diff --
Good suggestion, however IMO, it is a separated issue from removing the
type.
What do you think about that?
> Remove inet4 data type
> ----------------------
>
> Key: TAJO-2130
> URL: https://issues.apache.org/jira/browse/TAJO-2130
> Project: Tajo
> Issue Type: Task
> Reporter: Hyunsik Choi
> Assignee: Jongyoung Park
> Priority: Minor
>
> Inet4 data type is not necessary and is not used. It can be easily replaced
> by INT4 data type with some UDFs. Also, inet4 is overlapped with binary data
> types. Instead of keeping inet4, it would be better to improve binary data
> types.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
