[ 
https://issues.apache.org/jira/browse/TAJO-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362609#comment-15362609
 ] 

ASF GitHub Bot commented on TAJO-2165:
--------------------------------------

GitHub user dongjinleekr opened a pull request:

    https://github.com/apache/tajo/pull/1036

    TAJO-2165: Add 'ALTER TABLE UNSET PROPERTY' statement to Tajo DDL

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dongjinleekr/tajo feature/TAJO-2165

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/1036.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1036
    
----
commit 4ef3041c4a540242d364fc9d655ecc2cf0743434
Author: Lee Dongjin <[email protected]>
Date:   2016-07-04T12:28:45Z

    Implement TestAlterTable#testAlterTableUnSetProperty

commit e566766fd897831c8ccb25cc0f7b7dfa6d3c53a6
Author: Lee Dongjin <[email protected]>
Date:   2016-07-04T12:45:04Z

    1. AlterTableType#UNSET_PROPERTY 정의. 2. CatalogProtos.proto에 
AlterTableType#UNSET_PROPERTY, AlterTableDescProto#property_keys 추가.

commit 625e2201bfe561baa848a1a4fabcf2fc9c903908
Author: Lee Dongjin <[email protected]>
Date:   2016-07-04T12:56:00Z

    HiveCatalogStore#alterTable에 UNSET_PROPERTY 경우 추가

commit 960d6adb7fe310d7bc3e1a93e33a5c89d850f1af
Author: Lee Dongjin <[email protected]>
Date:   2016-07-04T13:08:44Z

    AlterTableDesc에 UNSET_PROPERTY 기능 추가

commit be1a4938a3d0a8827fe4676ef21b9df8cc31968a
Author: Lee Dongjin <[email protected]>
Date:   2016-07-04T13:17:14Z

    1. AbstractDBStore#unsetProperties 구현: RDBMS Catalog 값을 수정하는 기능. 2. 
AbstractDBStore#alterTable에 위 메소드를 호출하는 기능 추가. 3. 
TestCatalog#testAlterTableName -> TestCatalog#testAlterTable 4. 
TestCatalog#createMockAlterTableUnsetProperty 헬퍼 메소드 추가. 5. 
TestCatalog#testAlterTable에 AbstractDBStore#unsetProperties 테스트 추가.

commit c70805a97fc7bf8e9b4a7648c500b36ad1d8bace
Author: Lee Dongjin <[email protected]>
Date:   2016-07-04T15:35:08Z

    tajo-algebra에 alter table unset statement 구현

commit 4b691f56c5740ecf05e9150924c462b43a7e8ccd
Author: Lee Dongjin <[email protected]>
Date:   2016-07-04T15:45:25Z

    Lexer, Parser에 UNSET 예약어 및 문법 정의

commit 02e422913f8189b4548e55d9685c1fcdc197402a
Author: Lee Dongjin <[email protected]>
Date:   2016-07-04T15:55:00Z

    SQLAnalyzer 확장

commit ea9207a9cb31c8a1577b6438ffeb6636dcf85690
Author: Lee Dongjin <[email protected]>
Date:   2016-07-04T16:51:22Z

    Plan message (Plan.proto) 확장: alter table unset을 표현할 수 있도록 수정.

commit 89f453002287e63c30567ce8ed90d9a14e636cc7
Author: Lee Dongjin <[email protected]>
Date:   2016-07-04T16:58:13Z

    LogicalNode 자료구조 AlterTableNode 확장

commit b73a78ef35cbb29627ee2f59ac058e047928122c
Author: Lee Dongjin <[email protected]>
Date:   2016-07-04T16:59:32Z

    LogicalNodeSerializer, LogicalNodeDeserializer 확장: Logical Node <-> 
Protobuf message 기능 구현

commit 0f607247752d68ff7951fea8702b1d8f27e257ea
Author: Lee Dongjin <[email protected]>
Date:   2016-07-04T17:01:57Z

    LogicalPlanner에 UNSET PROPERTY 파싱 기능 추가

commit ac7f351c0b26bdb155f21e36efea565adb807f34
Author: Lee Dongjin <[email protected]>
Date:   2016-07-05T00:39:34Z

    Plan.proto의 AlterTableNode#propertyKeys 수정

commit 3be4bfc30015915ccba2b717cde9a0988e8d12b3
Author: Lee Dongjin <[email protected]>
Date:   2016-07-05T00:41:04Z

    CatalogUtil#unsetProperty 추가. DDLExecutor에 alter table unset문을 받아서 
CatalogUtil#unsetProperty를 호출해 주는 기능 추가.

commit 749b285c7bb8e766a91e47044b107c11e878bae1
Author: Lee Dongjin <[email protected]>
Date:   2016-07-05T14:01:50Z

    commit b73a78e에 누락되어 있던 부분 추가

commit e1cd8eec869a9ba3056615ec760f4b41c4ca66f7
Author: Lee Dongjin <[email protected]>
Date:   2016-07-05T14:12:33Z

    SQLAnalyzer 오류 수정

commit f540352bc85426c210db8d38887606a0874ef3a3
Author: Lee Dongjin <[email protected]>
Date:   2016-07-05T14:13:04Z

    commit 3be4bfc에 누락된 내용 추가

commit 9181f2f7e01643a506097741533761819a1a3e00
Author: Lee Dongjin <[email protected]>
Date:   2016-07-05T14:27:11Z

    SQLAnalyzer#evaluateAlterTableOperationTye 오류 수정

commit 6d2a28bd0c77d9d0b2d80a1f8e92c3aa18251253
Author: Lee Dongjin <[email protected]>
Date:   2016-07-05T14:28:12Z

    commit 0f60724에 누락된 부분 추가

commit c31235240bb83aa4d884ca76c49a5702510d0318
Author: Lee Dongjin <[email protected]>
Date:   2016-07-05T14:28:45Z

    TestAlterTable#testAlterTableUnSetProperty -> testAlterTableUnsetProperty 및 
기능 테스트 추가

----


> Add 'ALTER TABLE UNSET PROPERTY' statement to Tajo DDL
> ------------------------------------------------------
>
>                 Key: TAJO-2165
>                 URL: https://issues.apache.org/jira/browse/TAJO-2165
>             Project: Tajo
>          Issue Type: New Feature
>            Reporter: Lee Dongjin
>            Assignee: Lee Dongjin
>
> For version 0.11.x now, there is only set statement for table property. When 
> the user makes a typo with DDL statement, this mistake cannot be removed. We 
> also need the way to remove already set properties.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to