[
https://issues.apache.org/jira/browse/TAJO-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15365586#comment-15365586
]
ASF GitHub Bot commented on TAJO-2165:
--------------------------------------
Github user jinossy commented on a diff in the pull request:
https://github.com/apache/tajo/pull/1036#discussion_r69849676
--- Diff:
tajo-core-tests/src/test/java/org/apache/tajo/engine/query/TestAlterTable.java
---
@@ -88,6 +89,36 @@ public final void testAlterTableSetProperty() throws
Exception {
cleanupQuery(after_res);
}
+ @Test
+ public final void testAlterTableUnsetProperty() throws Exception {
+ executeDDL("table2_ddl.sql", "table2.tbl", "ALTY");
+ String tableName = IdentifierUtil.buildFQName(getCurrentDatabase(),
"alty");
+ assertTrue(catalog.existsTable(tableName));
+
+ TableDesc tableDesc = catalog.getTableDesc(tableName);
+ TableMeta tableMeta = tableDesc.getMeta();
+ assertEquals(tableMeta.getPropertySet().size(), 3);
+ assertNotNull(tableMeta.getProperty("timezone"));
+ assertNotNull(tableMeta.getProperty("text.null"));
+ assertEquals(tableMeta.getProperty("text.delimiter"), "\\u002b");
+
+ executeDDL("alter_table_unset_property_delimiter.sql", null);
+
+ tableDesc = catalog.getTableDesc(tableName);
+ tableMeta = tableDesc.getMeta();
+ assertEquals(tableMeta.getPropertySet().size(), 2);
+ assertNotNull(tableMeta.getProperty("timezone"));
+ assertNotNull(tableMeta.getProperty("text.null"));
--- End diff --
You should verify the unset property.
> Add 'ALTER TABLE UNSET PROPERTY' statement to Tajo DDL
> ------------------------------------------------------
>
> Key: TAJO-2165
> URL: https://issues.apache.org/jira/browse/TAJO-2165
> Project: Tajo
> Issue Type: New Feature
> Reporter: Lee Dongjin
> Assignee: Lee Dongjin
>
> For version 0.11.x now, there is only set statement for table property. When
> the user makes a typo with DDL statement, this mistake cannot be removed. We
> also need the way to remove already set properties.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
