[ 
https://issues.apache.org/jira/browse/TAJO-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15365596#comment-15365596
 ] 

ASF GitHub Bot commented on TAJO-2165:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/1036#discussion_r69850242
  
    --- Diff: 
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
 ---
    @@ -552,6 +552,16 @@ public static AlterTableDesc setProperty(String 
tableName, KeyValueSet params, A
         return alterTableDesc;
       }
     
    +  public static AlterTableDesc unsetProperty(String tableName, String[] 
propertyKeys, AlterTableType alterTableType) {
    --- End diff --
    
    Right. All those methods need to be refined. But, IMO, they are all 
internal APIs, and don't have to be consistent. So, I think that the new method 
has a better signature.


> Add 'ALTER TABLE UNSET PROPERTY' statement to Tajo DDL
> ------------------------------------------------------
>
>                 Key: TAJO-2165
>                 URL: https://issues.apache.org/jira/browse/TAJO-2165
>             Project: Tajo
>          Issue Type: New Feature
>            Reporter: Lee Dongjin
>            Assignee: Lee Dongjin
>
> For version 0.11.x now, there is only set statement for table property. When 
> the user makes a typo with DDL statement, this mistake cannot be removed. We 
> also need the way to remove already set properties.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to