[ 
https://issues.apache.org/jira/browse/TEZ-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14091384#comment-14091384
 ] 

Bikas Saha commented on TEZ-1216:
---------------------------------

We should not say delete staging dir as we are not deleting the staging dir 
(which is actually dangerous). We should say something like delete scratch 
files or delete temp files
{code}+  /** Whether to delete the staging dir on completion */
+  public static final String TEZ_AM_STAGING_DIR_AUTO_DELETE = TEZ_AM_PREFIX +
+      "staging-dir.auto-delete";
+  public static final boolean TEZ_AM_STAGING_DIR_AUTO_DELETE_DEFAULT = 
true;{code}

Can shutdownHandlerLock and shutdownHandlerRunning be merged?

s/unregisterSuccess/hasUnregistered

can you please explain the change in isLastAMRetry. Earlier we were 
unregistering if we were the last retry. Now we are not calling 
shouldUnregister flag on the TaskSchedulerService. Given that the default for 
this is false, it would mean the scheduler is never unregistering. How is 
everything working?



> Clean up the staging directory when the application completes
> -------------------------------------------------------------
>
>                 Key: TEZ-1216
>                 URL: https://issues.apache.org/jira/browse/TEZ-1216
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Mohammad Kamrul Islam
>            Assignee: Hitesh Shah
>            Priority: Critical
>         Attachments: TEZ-1216.1.patch, TEZ-1216.2.patch
>
>
> This JIRA is a part of TEZ-693. It includes the removal of stage directory 
> when application's last attempt is done. In addition, it will check a config 
> to determine whether to auto clean it or not.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to