[ 
https://issues.apache.org/jira/browse/TEZ-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14211400#comment-14211400
 ] 

Hitesh Shah commented on TEZ-14:
--------------------------------

Comments:

{code}
+  private boolean isSpeculationEnabled() {
+    return conf.getBoolean(TezConfiguration.TEZ_AM_SPECULATION_ENABLED,
+        TezConfiguration.TEZ_AM_SPECULATION_ENABLED_DEFAULT);
+  }
{code}
   - for ta.isSpeculationEnabled(), switch to a class member var?

 - TaskAttempStatusUpdateEventTransition indentation for a brace is a bit off

 - private static final long MAX_WAITTING_TIME_FOR_HEARTBEAT = 9 * 1000; - this 
might be problematic where the heartbeat value is wildly different. 

 - spurious change in 
tez-mapreduce/src/main/java/org/apache/tez/mapreduce/hadoop/MRJobConfig.java

More comments pending.
  


> Support for speculation of slow tasks
> -------------------------------------
>
>                 Key: TEZ-14
>                 URL: https://issues.apache.org/jira/browse/TEZ-14
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>         Attachments: TEZ-14.1.patch, TEZ-14.2.patch, TEZ-14.3.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to