[ 
https://issues.apache.org/jira/browse/TEZ-1826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14283375#comment-14283375
 ] 

Siddharth Seth commented on TEZ-1826:
-------------------------------------

Patch looks good mostly.
- JoinValidate is missing the printUsage changes. It'll be better to have the 
generic options printed by TezExampleBase itself, instead of changing the 
printUsage function in each example- "local", "disableGrouping" - similar to 
the way the hadoop options are printed.

- The local flag - It'll be good to add notes on this about the configuration 
being changed. Even though, not supported rightnow, it should be possible to 
run in local mode while accessing files from HDFS intead of localfs. Changing 
the FS in that case can completely break jobs. We can address this once there's 
a solution for TEZ-1348.


> Add option to disable grouping in some of the examples
> ------------------------------------------------------
>
>                 Key: TEZ-1826
>                 URL: https://issues.apache.org/jira/browse/TEZ-1826
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Siddharth Seth
>            Assignee: Jeff Zhang
>            Priority: Minor
>         Attachments: TEZ-1826-1.patch, TEZ-1826-2.patch, TEZ-1826-3.patch, 
> TEZ-1826-4.patch
>
>
> In Wordcount for instance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to