[ 
https://issues.apache.org/jira/browse/TEZ-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378769#comment-14378769
 ] 

Hitesh Shah commented on TEZ-2221:
----------------------------------

Understood but we should have 2 checks being done instead of re-writing the 
existing check. 

{code}
dag.createVertexGroup("group_1", v1,v2);
try {
  dag.createVertexGroup("group_1", v2,v3);
   Assert.fail();
} ...
try {
  dag.createVertexGroup("group_2", v1,v2);
   Assert.fail();
} ...
{code} 




  

> VertexGroup name should be unqiue
> ---------------------------------
>
>                 Key: TEZ-2221
>                 URL: https://issues.apache.org/jira/browse/TEZ-2221
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>         Attachments: TEZ-2221-1.patch
>
>
> VertexGroupCommitStartedEvent & VertexGroupCommitFinishedEvent use vertex 
> group name to identify the vertex group commit, the same name of vertex group 
> will conflict. While in the current equals & hashCode of VertexGroup, vertex 
> group name and members name are used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to