[
https://issues.apache.org/jira/browse/TEZ-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520743#comment-14520743
]
Hitesh Shah commented on TEZ-2221:
----------------------------------
Comments:
{code}
private Set<Set<Vertex>> vertexGroupMemberSets = Sets.newHashSet();
{code}
- should this ideally be Set<Set<String>> ?
{code}
throw new IllegalStateException(
"VertexGroup " + memberNames + " already defined!");
}
{code}
- minor re-wording: "VertexGroup " + memberNames + " already defined as
another group")
- nice-to-have: the other group that already has these members defined ( not
necessary if it makes the code complex ).
> VertexGroup name should be unqiue
> ---------------------------------
>
> Key: TEZ-2221
> URL: https://issues.apache.org/jira/browse/TEZ-2221
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Attachments: TEZ-2221-1.patch, TEZ-2221-2.patch, TEZ-2221-3.patch
>
>
> VertexGroupCommitStartedEvent & VertexGroupCommitFinishedEvent use vertex
> group name to identify the vertex group commit, the same name of vertex group
> will conflict. While in the current equals & hashCode of VertexGroup, vertex
> group name and members name are used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
