[jira] [Commented] (TEZ-2221) VertexGroup name should be unqiue

[Hitesh Shah (JIRA)]

    [ 
https://issues.apache.org/jira/browse/TEZ-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482129#comment-14482129
 ] 

Hitesh Shah commented on TEZ-2221:
----------------------------------

Minor nit: 

please add the following test too - diff group name with same group members: 

{code}
    try {
      dag.createVertexGroup("group_2", v1, v2);
      Assert.fail("should fail it due to duplicated VertexGroups");
    } catch (Exception e) {
      e.printStackTrace();
      Assert.assertEquals("...", e.getMessage());
    }
{code}

> VertexGroup name should be unqiue
> ---------------------------------
>
>                 Key: TEZ-2221
>                 URL: https://issues.apache.org/jira/browse/TEZ-2221
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>         Attachments: TEZ-2221-1.patch, TEZ-2221-2.patch
>
>
> VertexGroupCommitStartedEvent & VertexGroupCommitFinishedEvent use vertex 
> group name to identify the vertex group commit, the same name of vertex group 
> will conflict. While in the current equals & hashCode of VertexGroup, vertex 
> group name and members name are used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)