[
https://issues.apache.org/jira/browse/TEZ-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382751#comment-14382751
]
Hitesh Shah commented on TEZ-2205:
----------------------------------
bq. Is there something more beyond this I need to take care?
Yes - should a thread even be started to poll for events? In serviceStart and
serviceStop, it might be simpler to just see if timeline is disabled either by
checking client ==null or a different boolean and become no-ops. The service
started/stopped log message should not even show up if timeline is disabled.
This should be done in addition to whether events are queued.
TestContainerReuse is not related so you can ignore it. Being addressed in a
different jira.
> Tez still tries to post to ATS when yarn.timeline-service.enabled=false
> -----------------------------------------------------------------------
>
> Key: TEZ-2205
> URL: https://issues.apache.org/jira/browse/TEZ-2205
> Project: Apache Tez
> Issue Type: Sub-task
> Affects Versions: 0.6.1
> Reporter: Chang Li
> Assignee: Chang Li
> Attachments: TEZ-2205.1.patch, TEZ-2205.2.patch, TEZ-2205.wip.patch
>
>
> when set yarn.timeline-service.enabled=false, Tez still tries posting to ATS,
> but hits error as token is not found. Does not fail the job because of the
> fix to not fail job when there is error posting to ATS. But it should not be
> trying to post to ATS in the first place.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
