[
https://issues.apache.org/jira/browse/TEZ-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382860#comment-14382860
]
Hitesh Shah commented on TEZ-2205:
----------------------------------
Comments:
Minor nit: Assert.assertEquals(historyACLPolicyManager.timelineClient, null) ;
- use assertNull.
Also, can you modify the test to check the size of the queue at the end of the
run should be 0. I am guessing you will catch the issue I mention below by
adding this check.
bq. Does my current patch address the issue of queueing events correctly?
I think the latest patch accidentally removed the check of whether to add the
event to the queue. Currently, this will add events into the queue and never
empty the queue.
Rest looks good. I think we are getting very close to a final patch.
> Tez still tries to post to ATS when yarn.timeline-service.enabled=false
> -----------------------------------------------------------------------
>
> Key: TEZ-2205
> URL: https://issues.apache.org/jira/browse/TEZ-2205
> Project: Apache Tez
> Issue Type: Sub-task
> Affects Versions: 0.6.1
> Reporter: Chang Li
> Assignee: Chang Li
> Attachments: TEZ-2205.1.patch, TEZ-2205.2.patch, TEZ-2205.3.patch,
> TEZ-2205.4.patch, TEZ-2205.wip.patch
>
>
> when set yarn.timeline-service.enabled=false, Tez still tries posting to ATS,
> but hits error as token is not found. Does not fail the job because of the
> fix to not fail job when there is error posting to ATS. But it should not be
> trying to post to ATS in the first place.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
