[
https://issues.apache.org/jira/browse/TEZ-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382623#comment-14382623
]
Hitesh Shah commented on TEZ-2205:
----------------------------------
Comments:
Minor nit:
{code}
LOG.warn("ATSLogging service/acl manager is disabled "
+ "due to the Timeline Service is disabled");
{code}
Maybe use: atsHistoryLoggingServiceClassName + " is disabled due to Timeline
Service being disabled, "
+ YarnConfiguration.TIMELINE_SERVICE_ENABLED + " set to false"
bq. The changes in ATSHistoryLoggingService could be more optimal. If timeline
is disabled, why even bother queueing up events?
Previous review comment still not addressed.
> Tez still tries to post to ATS when yarn.timeline-service.enabled=false
> -----------------------------------------------------------------------
>
> Key: TEZ-2205
> URL: https://issues.apache.org/jira/browse/TEZ-2205
> Project: Apache Tez
> Issue Type: Sub-task
> Affects Versions: 0.6.1
> Reporter: Chang Li
> Assignee: Chang Li
> Attachments: TEZ-2205.1.patch, TEZ-2205.2.patch, TEZ-2205.wip.patch
>
>
> when set yarn.timeline-service.enabled=false, Tez still tries posting to ATS,
> but hits error as token is not found. Does not fail the job because of the
> fix to not fail job when there is error posting to ATS. But it should not be
> trying to post to ATS in the first place.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
