[
https://issues.apache.org/jira/browse/TEZ-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507563#comment-14507563
]
Bikas Saha commented on TEZ-2248:
---------------------------------
Would it make sense to add a finishedState member variable that can be set
along with terminationCause in trySetTerminationCause()? That way we could
allow different end states for the same termination cause (in case that
scenario arises in the future) instead of tying a cause to a state. We may need
to check that termiantionCause is being only set via trySetTerminationCause()
in all cases.
> VertexImpl/DAGImpl.checkForCompletion have too many termination cause checks
> ----------------------------------------------------------------------------
>
> Key: TEZ-2248
> URL: https://issues.apache.org/jira/browse/TEZ-2248
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Bikas Saha
> Assignee: Jeff Zhang
> Attachments: TEZ-2248-1.patch
>
>
> There is an if check for each termination cause which makes code long and we
> need to handle each new termination cause with more code. This could be
> abstracted into a method that gets termination cause string based on the enum
> and make this method shorter and stable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
