[
https://issues.apache.org/jira/browse/TEZ-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508254#comment-14508254
]
Jeff Zhang commented on TEZ-2248:
---------------------------------
[~bikassaha] I think finishedState member is only valid when terminationCause
is set, so I think it would be better to keep it as a member of
TerminationCause. And I think we don't need to make that change unless there's
a real scenario for that (different end states for the same termination cause),
always prefer to do refactoring when it is necessary :) Any thoughts ?
Post another patch ( make a little change to use trySetTerminationCause in all
cases )
> VertexImpl/DAGImpl.checkForCompletion have too many termination cause checks
> ----------------------------------------------------------------------------
>
> Key: TEZ-2248
> URL: https://issues.apache.org/jira/browse/TEZ-2248
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Bikas Saha
> Assignee: Jeff Zhang
> Attachments: TEZ-2248-1.patch, TEZ-2248-2.patch
>
>
> There is an if check for each termination cause which makes code long and we
> need to handle each new termination cause with more code. This could be
> abstracted into a method that gets termination cause string based on the enum
> and make this method shorter and stable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
