[
https://issues.apache.org/jira/browse/TEZ-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509400#comment-14509400
]
Bikas Saha commented on TEZ-2248:
---------------------------------
Sounds good. +1. Minor comment - Lets say "did not succeed due to" instead of
"killed/failed/error due to".
> VertexImpl/DAGImpl.checkForCompletion have too many termination cause checks
> ----------------------------------------------------------------------------
>
> Key: TEZ-2248
> URL: https://issues.apache.org/jira/browse/TEZ-2248
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Bikas Saha
> Assignee: Jeff Zhang
> Attachments: TEZ-2248-1.patch, TEZ-2248-2.patch
>
>
> There is an if check for each termination cause which makes code long and we
> need to handle each new termination cause with more code. This could be
> abstracted into a method that gets termination cause string based on the enum
> and make this method shorter and stable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
