[ 
https://issues.apache.org/jira/browse/TEZ-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527549#comment-14527549
 ] 

Bikas Saha commented on TEZ-2221:
---------------------------------

Disallowing this should be ok and sounds related to the jira since the output 
committer is identified by the vertex group name.
{code}
dag.createVertexGroup("group_1", v1,v2);
dag.createVertexGroup("group_1", v2,v3);
{code}

Would like to understand why this is being disallowed? From what I see this 
would work for the async commit logic, since each async commit per output per 
vertex in the group. So separating by group name should be ok.
{code}
dag.createVertexGroup("group_1", v1,v2);
dag.createVertexGroup("group_2", v1,v2);
{code}
Is there any use case that can be supported here but not by combining them?


> VertexGroup name should be unqiue
> ---------------------------------
>
>                 Key: TEZ-2221
>                 URL: https://issues.apache.org/jira/browse/TEZ-2221
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>             Fix For: 0.7.0, 0.5.4, 0.6.1
>
>         Attachments: TEZ-2221-1.patch, TEZ-2221-2.patch, TEZ-2221-3.patch, 
> TEZ-2221-4.patch
>
>
> VertexGroupCommitStartedEvent & VertexGroupCommitFinishedEvent use vertex 
> group name to identify the vertex group commit, the same name of vertex group 
> will conflict. While in the current equals & hashCode of VertexGroup, vertex 
> group name and members name are used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to