[
https://issues.apache.org/jira/browse/TEZ-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653238#comment-14653238
]
Bikas Saha commented on TEZ-2633:
---------------------------------
Thanks for the reviews! I added some usage for the new identifiers to ensure
there is test coverage before committing them. Internal id's implementing the
interface is a good idea but is a lot of work given the number of places where
we create these id's and making sure vertex name etc. are available. TezDAGId
itself does not have an attempt number - so getting the attempt number from the
app is also something that needs some work. I will create a follow up for this.
Having TezId's implement the interface would also solve the instance problem by
reusing the existing instance caching code.
For now, I have removed the causal attempt identifier. So that should remove
the corner case code in the comments above. [~rajesh.balamohan] Could you
please complete the review with the latest patch when you have time. Thanks!
> Allow VertexManagerPlugins to receive and report based on attempts instead of
> tasks
> -----------------------------------------------------------------------------------
>
> Key: TEZ-2633
> URL: https://issues.apache.org/jira/browse/TEZ-2633
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: TEZ-2633.1.patch, TEZ-2633.2.patch
>
>
> If the same event is sent from an attempt and its retry then there is no way
> to differentiate between them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
