[
https://issues.apache.org/jira/browse/TEZ-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654901#comment-14654901
]
Rajesh Balamohan commented on TEZ-2633:
---------------------------------------
Lgtm overall. +1. Ignoring findbugs warnings mentioned in the the new
identifiers as they are fixed in .4 version. Minor comments.
- Should changes related to handling of duplicate VMEvents in
ShuffleVertexManager added in a separate JIRA?
- TestImmediateStartVertexManager & TestShuffleVertexManager - Should it be
null instead of emptyCompletions?
- Is default implementation of
VertexManagerPlugin.onVertexStarted(List<TaskAttemptIdentifier> completions)
provided for backward compatability?
- Remove TaskWithLocationHint in TestVertexImpl before commit
> Allow VertexManagerPlugins to receive and report based on attempts instead of
> tasks
> -----------------------------------------------------------------------------------
>
> Key: TEZ-2633
> URL: https://issues.apache.org/jira/browse/TEZ-2633
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: TEZ-2633.1.patch, TEZ-2633.2.patch, TEZ-2633.3.patch,
> TEZ-2633.4.patch
>
>
> If the same event is sent from an attempt and its retry then there is no way
> to differentiate between them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
