[
https://issues.apache.org/jira/browse/TEZ-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658569#comment-14658569
]
Bikas Saha commented on TEZ-2633:
---------------------------------
bq. Should changes related to handling of duplicate VMEvents in
ShuffleVertexManager added in a separate JIRA?
Thats done here to verify that the code changes actually work. E.g. using the
identifiers in maps etc.
bq. TestImmediateStartVertexManager & TestShuffleVertexManager - Should it be
null instead of emptyCompletions?
emptyCompletions is actually null. Simply passing null confuses the compiler
because it does not understand if null maps to the List version or the
deprecated Map version.
bq. Is default implementation of
VertexManagerPlugin.onVertexStarted(List<TaskAttemptIdentifier> completions)
provided for backward compatability?
Yes. This prevents build break until users change to the new API's
bq. Remove TaskWithLocationHint in TestVertexImpl before commit
Done.
Thanks for the reviews. Committing in a bit.
> Allow VertexManagerPlugins to receive and report based on attempts instead of
> tasks
> -----------------------------------------------------------------------------------
>
> Key: TEZ-2633
> URL: https://issues.apache.org/jira/browse/TEZ-2633
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: TEZ-2633.1.patch, TEZ-2633.2.patch, TEZ-2633.3.patch,
> TEZ-2633.4.patch
>
>
> If the same event is sent from an attempt and its retry then there is no way
> to differentiate between them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
