[
https://issues.apache.org/jira/browse/TEZ-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907631#comment-14907631
]
Bikas Saha commented on TEZ-2851:
---------------------------------
looks good overall.
* missing javadoc for dag api
* CalledContext.create() instead of constructor for consistency?
* confusing that callerId and callerType are the required ATS entities, yet
callerContext and description seem to be the minimum required arguments to the
constructor. Should instead callerId and callerType be the required arguments?
* TestDAGUtils missing check for the actual converted context map?
* inconsistent null checking for various members - different places are
checking/not-checking for nulls for different members
(proto/timeline/json/dagplan serde)
* only 2 members of caller context go to ATS? in HistoryTimelineConversion
* e2e real life test could be added in existing testcase in TestHistoryParser.
This also covers simple history compatibility.
> Support a way for upstream applications to pass in a caller context to Tez
> --------------------------------------------------------------------------
>
> Key: TEZ-2851
> URL: https://issues.apache.org/jira/browse/TEZ-2851
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Hitesh Shah
> Assignee: Hitesh Shah
> Attachments: TEZ-2851.1.patch, TEZ-2851.2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
