[
https://issues.apache.org/jira/browse/TEZ-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14908785#comment-14908785
]
Hitesh Shah commented on TEZ-2851:
----------------------------------
bq. missing javadoc for dag api
bq. CalledContext.create() instead of constructor for consistency?
Fixed.
bq. confusing that callerId and callerType are the required ATS entities, yet
callerContext and description seem to be the minimum required arguments to the
constructor. Should instead callerId and callerType be the required arguments?
Current functionality has been providing just the context and description via
dagInfo ( not as formal args ). Caller Id and type are new additions. I am not
sure whether callerId+type will be applicable in all scenarios hence the 2
approaches ( context+desc only or all 4 args needed ). Context is always needed
and desc is optional.
bq. inconsistent null checking for various members - different places are
checking/not-checking for nulls for different members
(proto/timeline/json/dagplan serde)
Fixed.
bq. only 2 members of caller context go to ATS? in HistoryTimelineConversion
Not really. 2 explicitly added to otherInfo but full data serialized as part of
dagPlan.
bq. e2e real life test could be added in existing testcase in
TestHistoryParser. This also covers simple history compatibility.
Fixed.
bq. TestDAGUtils missing check for the actual converted context map?
Fixed in upcoming patch.
> Support a way for upstream applications to pass in a caller context to Tez
> --------------------------------------------------------------------------
>
> Key: TEZ-2851
> URL: https://issues.apache.org/jira/browse/TEZ-2851
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Hitesh Shah
> Assignee: Hitesh Shah
> Attachments: TEZ-2851.1.patch, TEZ-2851.2.patch, TEZ-2851.3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
