[ 
https://issues.apache.org/jira/browse/TEZ-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003855#comment-15003855
 ] 

Sreenath Somarajapuram commented on TEZ-2923:
---------------------------------------------

Thank you so much [~jeagles]. 
Few observations/comments:
- There is already a task-counters-controller.js file, so content of 
task_counters_controller.js can be added to that.
- Might be better to remove shared-controllers.js as it wont be used now.
- Not sure if the port change in default-configs.js was intentional
- In App.Helpers.emData.mergeRecords, there are cases when info would come 
undefined. So in line 34 its better to add a check for info before info.get. 
Something like "if(info && info.get('counters'))"


> Tez Live UI counters view empty for vertices, tasks, attempts
> -------------------------------------------------------------
>
>                 Key: TEZ-2923
>                 URL: https://issues.apache.org/jira/browse/TEZ-2923
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Jonathan Eagles
>            Assignee: Jonathan Eagles
>         Attachments: TEZ-2293.1.patch, TEZ-2923.2.patch, TEZ-2923.3.patch, 
> TEZ-2923.4.patch, TEZ-2923.5.patch
>
>
> Vertex Counters, Task Counters, and TaskAttempt Counters views are blank 
> during the live tez AM view. This is due to the nature of the request sent by 
> the Tez UI to the Tez AM rest api. The api only accepts a list of counter 
> groups or counter names, since the groups and names are unknown at the time 
> of the request, there is no away to ask for counters by name. This jira 
> proposes to allow for a "*" to the rest api to request all counters to be 
> returned.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to