[
https://issues.apache.org/jira/browse/TEZ-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008682#comment-15008682
]
Bikas Saha commented on TEZ-2581:
---------------------------------
NoOpVertexManager
- Please remove or guard debug log stmts.
TaskImpl.java
- This is not needed, right?
{code}
+ protected TezTaskAttemptID getSchedulingCausalTA() {
+ return schedulingCausalTA;
+ }{code}
Also, should we send a TA_KILLED event here? That would killed the attempt
(after success) and do the necessary things for that (e.g. notify that its
events are failed to its consumers). Then TA would go to killed state and
notify Task. And then task would reschedule new attempt (existing flow).
However, looking at the TA_KILLED handling, it seems that for leaf tasks, this
transition ignores the event and does nothing (which would be wrong here).
bq. Because this require moving the relationship between the event type and
target state from state machine in the Terminatetransition , which looks weird
and not easy to maintain
Sorry, I did not understand. Could you please clarify?
> Umbrella for Tez Recovery Redesign
> ----------------------------------
>
> Key: TEZ-2581
> URL: https://issues.apache.org/jira/browse/TEZ-2581
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Attachments: TEZ-2581-WIP-1.patch, TEZ-2581-WIP-10.patch,
> TEZ-2581-WIP-11.patch, TEZ-2581-WIP-12.patch, TEZ-2581-WIP-13.patch,
> TEZ-2581-WIP-2.patch, TEZ-2581-WIP-3.patch, TEZ-2581-WIP-4.patch,
> TEZ-2581-WIP-5.patch, TEZ-2581-WIP-6.patch, TEZ-2581-WIP-7.patch,
> TEZ-2581-WIP-8.patch, TEZ-2581-WIP-9.patch, TezRecoveryRedesignProposal.pdf,
> TezRecoveryRedesignV1.1.pdf
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
