[
https://issues.apache.org/jira/browse/TEZ-2581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15001892#comment-15001892
]
Bikas Saha commented on TEZ-2581:
---------------------------------
bq. Secondly, for handling commit recovery, would it be possible to do the
check and recovery of commit operation in the recovery flow of the ta_done
inside the attempt itself. That way the full responsibility of recovering the
attempt (including its commit) will stay in the attempt instead of spilling
over into the task? IF you think this would be better, we can do it in a follow
up jira or within this patch, your call.
Did you miss responding to the above comment?
bq. This is because All the Termination related transition extends
TerminateTransition
Got it. Alternatively, if changing the singleArcTransition to a MultipleArc
also sounds feasible by adding a return state that defaults to fail_in_progress
and is overridden to failed state only in the recovery case. The multiple arc
transition seems more generic and may be used in the future for other things
that want to short circuit the transition IMO.
I agree with your comments on the existing system tests added as its important
to verify results. If you are saying that cases like III, HHH, DDD are already
covered then why open TEZ-2939? (not sure since there is no description). We
can close it if the cases are already covered.
> Umbrella for Tez Recovery Redesign
> ----------------------------------
>
> Key: TEZ-2581
> URL: https://issues.apache.org/jira/browse/TEZ-2581
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Attachments: TEZ-2581-WIP-1.patch, TEZ-2581-WIP-10.patch,
> TEZ-2581-WIP-11.patch, TEZ-2581-WIP-2.patch, TEZ-2581-WIP-3.patch,
> TEZ-2581-WIP-4.patch, TEZ-2581-WIP-5.patch, TEZ-2581-WIP-6.patch,
> TEZ-2581-WIP-7.patch, TEZ-2581-WIP-8.patch, TEZ-2581-WIP-9.patch,
> TezRecoveryRedesignProposal.pdf, TezRecoveryRedesignV1.1.pdf
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
