simhadri-g commented on code in PR #374:
URL: https://github.com/apache/tez/pull/374#discussion_r1878634869
##########
tez-dag/src/main/java/org/apache/tez/dag/app/rm/YarnTaskSchedulerService.java:
##########
@@ -2163,6 +2166,17 @@ void addDelayedContainer(Container container,
}
}
+ void removeDelayedContainer(HeldContainer container) {
+ if (container != null) {
+ synchronized(this) {
+ if (delayedContainers.remove(container)) {
+ LOG.info("Removed {} from delayed containers",
container.getContainer().getId());
+ } else {
+ LOG.warn("Unknown container {} sent for removal. Ignoring.",
container.getContainer().getId());
Review Comment:
nit: I think we should change the log level to debug and print the only if
LOG.isDebugEnabled() is true,
Similar to :
https://github.com/apache/tez/pull/374/files#diff-aaf0735de6615f8eeb8469ceadca2c3b0cdd578544a2564c37b299c55347188eR1548-R1550
Rest of the code LGTM .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
