abstractdog commented on PR #374:
URL: https://github.com/apache/tez/pull/374#issuecomment-2558033669

   thanks @himanshu-mishra for taking care of this
   
   according to the description of 
[TEZ-1742](https://issues.apache.org/jira/browse/TEZ-1742):
   ```
   Tez YARN Task Scheduler currently preempts 1 running task at a time when a 
higher priority task is waiting and there are no available resources. When a 
large number of higher priority tasks are pending then it can take a long time 
to preempt the required number of lower priority tasks.
   ```
   after checking and trying out the unit test and the fix here, it seems like 
this patch what's exactly fixes the abovementioned problem
   
   apart from the assertion error fix, the unit test indeed proves that 
releaseAssignedContainer is called as many times as needed according to the 
percentage config in a single round, so this looks good to me
   
   only left a minor comment regarding a null check
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to