abstractdog commented on code in PR #374:
URL: https://github.com/apache/tez/pull/374#discussion_r1894577963
##########
tez-dag/src/main/java/org/apache/tez/dag/app/rm/YarnTaskSchedulerService.java:
##########
@@ -2163,6 +2166,17 @@ void addDelayedContainer(Container container,
}
}
+ void removeDelayedContainer(HeldContainer container) {
+ if (container != null) {
+ synchronized(this) {
+ if (delayedContainers.remove(container)) {
+ LOG.info("Removed {} from delayed containers",
container.getContainer().getId());
+ } else {
+ LOG.warn("Unknown container {} sent for removal. Ignoring.",
container.getContainer().getId());
Review Comment:
not sure about the log levels, let's keep the simple remove path on debug:
```
LOG.debug("Removed {} from delayed containers",
container.getContainer().getId());
```
isDebugEnabled is not necessary as long as we use the {} formatting (to
prevent unnecessary string creation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
