abstractdog commented on PR #386: URL: https://github.com/apache/tez/pull/386#issuecomment-2566284909
> @abstractdog This is Runtime compatibility right? not Compile time, for compile time, we should change this to 17: > > https://github.com/apache/tez/blob/c7a3791e971e30b47ce3a4a465e507a43f609ade/pom.xml#L44 > > As of now it is hardcoded 1.8 which is JDK-8 for 17 it should be changed to 17, or is there some place we do that which I missed? hm, good question, I usually struggle with maven options like this honestly...what's driven by this patch is that the precommit will simply compile the source with different java versions, which is the same thing I achieve by pointing the java/javac etc. commands to a different JAVA_HOME (hence chaging java version) before compiling the code whether maven should do any enforcement in this scenario is a different question -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
