abstractdog commented on PR #386: URL: https://github.com/apache/tez/pull/386#issuecomment-2566451950
> We can change the title to mention Runtime rather than compile time, same as in Hadoop it has runtime capabilities but doesn’t claim compile time bcoz the maven version is set as 1.8 changing doesn’t work either, that is something we also need to see what happens in case of Tez > > and for 1.0 we can bump it to 17 and claim compile time compat. > > anyway I am +1 here okay, I think I got your point, so it would be confusing to claim "compatibility" with stil using 1.8 -source and -target javac arguments this PR does nothing more than enable a github action, that complies with the existing code with existing javac settings, so a title like this below is indeed more straightforward: ``` Enable github action to compile with JDK 17 ``` wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
