abstractdog commented on PR #386: URL: https://github.com/apache/tez/pull/386#issuecomment-2566334953
> As of now the byte code would be for JDK 8 only https://stackoverflow.com/a/38883073 > > to have the byte code for JDK-17 we need to change that to 17 > > this is the offcial doc: https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-source-and-target.html > > Maybe we can merge this with a changed title and explore the compile stuff in seperate ticket hm, okay, I just refreshed the source/target javac options a bit :D what settings are recommended here? in my understanding: the source version specifies the language features and syntax that the compiler should allow, while the target version specifies the bytecode compatibility for the Java runtime according to official documentation (https://docs.oracle.com/javase/7/docs/technotes/tools/windows/javac.html#crosscomp-example) and other articles, -target defines the lowest JDK runtime version that we're about to make the code able to run against, I believe we haven't changed the project state at all from this point of view, right? I mean, now with TEZ-4387 merged, we're able to compile against JDK17, but e.g. we haven't told that the minimum supported JDK version is anything greater than 8 hence the "Check compile-time compatibility with JDK 17 in precommit" makes sense do you agree with the above points? what title do you recommend? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
