abstractdog commented on code in PR #461:
URL: https://github.com/apache/tez/pull/461#discussion_r2878566539
##########
tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java:
##########
@@ -443,6 +437,16 @@ protected void serviceInit(final Configuration conf)
throws Exception {
this.isLocal = conf.getBoolean(TezConfiguration.TEZ_LOCAL_MODE,
TezConfiguration.TEZ_LOCAL_MODE_DEFAULT);
+ if (!isLocal) {
+ this.nmHost = nodeContext.getNodeHostString();
+ int nmHttpPort = Integer.parseInt(nodeContext.getNodeHttpPortString());
+ this.containerLogs =
+ getRunningLogURL(
+ this.nmHost + ":" + nmHttpPort,
Review Comment:
could you eliminate this.nmHost field? I feel that as long as we have
NodeContext, DAGAppMaster should use it where it's possible to retrieve node
information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
