Aggarwal-Raghav commented on code in PR #461:
URL: https://github.com/apache/tez/pull/461#discussion_r2884121958
##########
tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java:
##########
@@ -1207,15 +1208,15 @@ public ContainerId getAppContainerId() {
}
public String getAppNMHost() {
- return nmHost;
+ return nodeContext.getNodeHostString();
}
public int getAppNMPort() {
- return nmPort;
+ return nodeContext.getNodePort();
}
public int getAppNMHttpPort() {
- return nmHttpPort;
+ return nodeContext.getNodeHttpPort();
Review Comment:
i thought so but they are `public` api, but its a tez major version change
so we can do so. I wanted to discuss the same with you. Let me know.
there are few variables that can be made final and local to method instead
of class varaibles in DagAppMaster. I wanted to clean that up and use JDK 21
features like `enhanced switch` but the change would have been outside the
scope of PR. I can create a separte PR for code hygiene?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
